-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating cve advisory for kops-1.7.1 release #3580
updating cve advisory for kops-1.7.1 release #3580
Conversation
chrislovecnm
commented
Oct 10, 2017
- fixed line wrap
- fixed typos
- added updates for kops 1.7.1 release
0b4bf65
to
f459ae4
Compare
/approved |
f459ae4
to
fdb4670
Compare
/approve |
docs/advisories/cve_2017_14491.md
Outdated
|
||
## Current kops Status | ||
|
||
As of 2017/10/08 `kops` fixes are not in a released `kops` version, but you are | ||
able to hotfix any Kubernetes cluster that is 1.4.x or higher. | ||
`kop` release 1.7.1 addresses this CVE. This version of `kops` will upgrade and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: kops
docs/advisories/cve_2017_14491.md
Outdated
As of 2017/10/08 `kops` fixes are not in a released `kops` version, but you are | ||
able to hotfix any Kubernetes cluster that is 1.4.x or higher. | ||
`kop` release 1.7.1 addresses this CVE. This version of `kops` will upgrade and | ||
create clusters. `kops` 1.8.x release does not contain the required changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.8.0-alpha.1 doesn't, but alpha.2 and up will
docs/advisories/cve_2017_14491.md
Outdated
|
||
## Upgrading Cluster | ||
|
||
To update a cluster. The kube-dns deployment will be automatically upgraded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dangling sentence
-o jsonpath='{.spec.template.spec.containers[?(@.name == "dnsmasq")].image}' | ||
``` | ||
|
||
The upgrade is will occur once the channels utilty picks up the change within a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grammar and typo in mintues
docs/advisories/cve_2017_14491.md
Outdated
@@ -126,4 +162,4 @@ _TODO_ if someone wants to provide the output. | |||
|
|||
## Thanks | |||
|
|||
Thanks to @mikesplain, @chrislovecnm, @snoby, @justinsb, @3h4x | |||
Thanks to all that helped @mikesplain, @chrislovecnm, @snoby, @justinsb, @3h4x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add aaronlevy here also
docs/advisories/cve_2017_14491.md
Outdated
upgrading to tested version is recommended. We have had 1.4.x users upgrade | ||
successfully, but we cannot validate full production stability. Local testing | ||
in a non-production environment is always recommended. We are not able to | ||
quatify the risk of using a non-tested version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quantify
@justinsb PTAL, cleaned up english |
|
||
#### Installation of Hot Fix | ||
|
||
Apply the update to the container: | ||
|
||
```bash | ||
kubectl set image deployment/kube-dns -n kube-system dnsmasq=gcr.io/google_containers/k8s-dns-dnsmasq-amd64:1.14.5 | ||
kubectl set image deployment/kube-dns -n kube-system \ | ||
dnsmasq=gcr.io/google_containers/k8s-dns-dnsmasq-amd64:1.14.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be k8s-dns-dnsmasq-nanny-amd64:1.14.5
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, I think naming changed. Although nanny
is still mentioned in validation steps.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue. |