Grant kubelets system:node role in 1.8 #3683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
chrislovecnm
approved these changes
Oct 22, 2017
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-github-robot
added
the
approved
This is an interim measure until we fully support the NodeAuthorizer and dynamic kubelet bootstrapping. Issue kubernetes#3551
|
/lgtm cancel //PR changed after LGTM, removing LGTM. @chrislovecnm @justinsb |
k8s-github-robot
removed
the
lgtm
|
@justinsb PR needs rebase |
k8s-github-robot
added
the
needs-rebase
justinsb
force-pushed
the
kubelet_node_role
branch
from
eaa7169 to
15d50af
Compare
k8s-github-robot
removed
the
needs-rebase
|
Rebased & fixed tests (hopefully) |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
This was referenced Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an interim measure until we fully support the NodeAuthorizer and
dynamic kubelet bootstrapping.
Issue #3551