Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding -y #3767

Merged
merged 1 commit into from
Nov 6, 2017
Merged

adding -y #3767

merged 1 commit into from
Nov 6, 2017

Conversation

chrislovecnm
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2017
@k8s-github-robot
Copy link

@chrislovecnm PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 5, 2017
@andrewsykim
Copy link
Member

Should we add an equivalent for update cluster?

@justinsb
Copy link
Member

justinsb commented Nov 5, 2017

/lgtm

The conflict means this LGTM won't do any good though :-( But feel free to rebase and self-lgtm

And I certainly agree with adding it to other places as well @andrewsykim

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2017
@chrislovecnm
adding -y to various commands that use --yes. kops create,
a25b5d7 
rolling-update and update now include -y.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2017
@k8s-github-robot
Copy link

/lgtm cancel //PR changed after LGTM, removing LGTM. @andrewsykim @chrislovecnm @geojaz @justinsb

@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 6, 2017
@chrislovecnm
Copy link
Contributor Author

@andrewsykim PTAL

andrewsykim
andrewsykim reviewed Nov 6, 2017
View reviewed changes
cmd/kops/update_federation.go
@@ -34,7 +34,7 @@ var (

update_federation_example = templates.Examples(i18n.T(`
# After cluster has been edited or upgraded, configure it with:
kops update federation k8s-cluster.example.com --yes --state=s3://kops-state-1234 --yes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to keep at least one --yes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no --yes on the options object unless I missed it

andrewsykim
andrewsykim reviewed Nov 6, 2017
View reviewed changes
docs/cli/kops_update_federation.md
@@ -18,7 +18,7 @@ kops update federation

```
# After cluster has been edited or upgraded, configure it with:
kops update federation k8s-cluster.example.com --yes --state=s3://kops-state-1234 --yes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, did you mean to leave 1 --yes?

@andrewsykim
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:
  • OWNERS [andrewsykim,justinsb]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 830232d into kubernetes:master Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

Assignees

@justinsb justinsb

@geojaz geojaz

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chrislovecnm @k8s-github-robot @andrewsykim @justinsb @geojaz @k8s-ci-robot