Refactor: clean up SecretStore to not use KeystoreItem #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
@justinsb PR needs rebase |
k8s-github-robot
added
the
needs-rebase
justinsb
force-pushed
the
cleanup_ssh_3
branch
from
a8705b3 to
d079530
Compare
k8s-ci-robot
added
size/L
k8s-github-robot
removed
the
needs-rebase
|
@justinsb PR needs rebase |
k8s-github-robot
added
the
needs-rebase
More moving to use API objects, except in this case we eventually want to deprecate SecretStore entirely.
justinsb
force-pushed
the
cleanup_ssh_3
branch
from
d079530 to
7f3d354
Compare
k8s-ci-robot
added
size/M
k8s-github-robot
removed
the
needs-rebase
chrislovecnm
approved these changes
Dec 19, 2017
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
k8s-github-robot
pushed a commit
that referenced
this pull request
Dec 20, 2017
Automatic merge from submit-queue. Avoid ListSecrets call in nodeup This helps up with GCE permissions, but also helps us get rid of auth tokens. Builds on #3834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More moving to use API objects, except in this case we eventually want to
deprecate SecretStore entirely.
Builds on #3833