Remove use of deprecated create-if-missing functions #3836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
@justinsb PR needs rebase |
k8s-github-robot
added
the
needs-rebase
justinsb
force-pushed
the
avoid_list_for_keypairs
branch
from
fc66d27 to
5ff6b29
Compare
k8s-ci-robot
added
size/L
k8s-github-robot
removed
the
needs-rebase
justinsb
force-pushed
the
avoid_list_for_keypairs
branch
from
5ff6b29 to
85dc006
Compare
|
@justinsb PR needs rebase |
k8s-github-robot
added
the
needs-rebase
justinsb
force-pushed
the
avoid_list_for_keypairs
branch
from
85dc006 to
7ef0e9b
Compare
k8s-github-robot
removed
the
needs-rebase
Generally tightening up the interface to make it easier to remove list operations.
justinsb
force-pushed
the
avoid_list_for_keypairs
branch
from
7ef0e9b to
9e5c086
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
chrislovecnm
approved these changes
Dec 20, 2017
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
k8s-github-robot
pushed a commit
that referenced
this pull request
Dec 21, 2017
Automatic merge from submit-queue. Refactor VFS CA store to reuse keyset from clientset This ensures the two behave more similarly, but also will help us parse a serialized keyset. Builds on #3836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally tightening up the interface to make it easier to remove list
operations.
Builds on #3835