-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump all flannel versions to latest release - v0.9.1 #3880
Conversation
Hi @tomdee. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for the PR! First off can we not update both flannel and Canal in the same commit? Also we need to update version in bootstrapchannelbuilder.go See https://github.com/kubernetes/kops/pull/3869/files#diff-e6c11b77cff2eb23d70f34c74ae63563R472 /assign @KashifSaadat @KashifSaadat should we be using this version of flannel? |
Thanks @tomdee - I'm going to go ahead and merge this; I'll cc you on the PR that bumps bootstrapchannelbuilder.go Is there any difference between quay.io/coreos/flannel:v0.9.1 and quay.io/coreos/flannel:v0.9.1-amd64 ? /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
No description provided.