Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put stable channel back to jessie for 1.9 / 1.10 #4002

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Put stable channel back to jessie for 1.9 / 1.10 #4002

merged 1 commit into from
Dec 4, 2017

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Dec 4, 2017 •
edited
Loading

Otherwise we're blocking the queue:
kubernetes/kubernetes#56763

Nobody is running 1.10 in stable anyway. 1.9 is more questionable, but hopefully we can get this resolved quickly.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2017
@justinsb
Put stable channel back to jessie for 1.9 / 1.10
7f36b0e 
Otherwise we're blocking the queue:
kubernetes/kubernetes#56763

Nobody is running 1.10 in stable anyway.  1.9 is more questionable, but
hopefully we can get this resolved quickly.
@justinsb justinsb force-pushed the put_stable_110_back_to_jessie branch from dda3768 to 7f36b0e Compare December 4, 2017 00:37
@justinsb justinsb changed the title Put stable channel back to jessie for 1.10 Put stable channel back to jessie for 1.9 / 1.10 Dec 4, 2017
@justinsb justinsb mentioned this pull request Dec 4, 2017
Closed
@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2017
@k8s-ci-robot
Copy link
Contributor

@justinsb: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kops-e2e-kubernetes-aws 7f36b0e link /test pull-kops-e2e-kubernetes-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justinsb
Copy link
Member Author

justinsb commented Dec 4, 2017

Going to force merge - that failure is exactly what we're fixing ^^

@justinsb justinsb merged commit e633bb4 into kubernetes:master Dec 4, 2017
@MOZGIII
Copy link

MOZGIII commented Apr 16, 2018

Can this be reverted now? Seems like it's fixed in kubernetes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm chrislovecnm approved these changes

Assignees

@chrislovecnm chrislovecnm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justinsb @chrislovecnm @k8s-ci-robot @MOZGIII