Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove world read permissions on sensitive key files. #4022

Merged
merged 1 commit into from
Dec 14, 2017
Merged

Remove world read permissions on sensitive key files. #4022

merged 1 commit into from
Dec 14, 2017

Conversation

KashifSaadat
Copy link
Contributor

@KashifSaadat KashifSaadat commented Dec 7, 2017 •
edited
Loading

The key files pulled from S3 had world read permissions by default (644). This PR sets the permissions to 600 on .key and .pem files.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 7, 2017
@gambol99
Copy link
Contributor

gambol99 commented Dec 7, 2017 •
edited
Loading

In general ltgm, it's best practice ... difficult one to test as some addon, daemonset etc might reuse those certs (take kube-auth for example which i don't think it runs as root)

@KashifSaadat
Copy link
Contributor Author

@gambol99 good point, maybe one to include in notes / required actions on a following kops release if that's sufficient?

/assign @chrislovecnm

@justinsb
Copy link
Member

/lgtm

I'm not too worried about a release note, though I have no objection to doing so. I don't want to create an expectation that the location of these files on the node (or their readability) is some sort of guarantee that kops is making other than to the components we are configuring them for.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 5e2251b into kubernetes:master Dec 14, 2017
@KashifSaadat KashifSaadat deleted the keyfile-permissions branch December 29, 2017 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

@chrislovecnm chrislovecnm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KashifSaadat @gambol99 @justinsb @k8s-ci-robot @k8s-github-robot @chrislovecnm