Adding DescribeTags to masters

[robinpercy]

/fixes #2681

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[gambol99]

hi @robinpercy ...CI isn't happy ... i believe you need to update the

$ ls tests/integration/update_cluster/{additional_user-data,minimal-cloudformation}
tests/integration/update_cluster/additional_user-data:
cloudformation.json  cloudformation.json.extracted.yaml  id_rsa.pub  in-v1alpha2.yaml

tests/integration/update_cluster/minimal-cloudformation:
cloudformation.json  cloudformation.json.extracted.yaml  id_rsa.pub  in-v1alpha2.yaml

to fix the TestMinimalCloudformation and TestAdditionalUserData

[gambol99]

/assign

[robinpercy]

Thanks @gambol99. Not sure how I missed those.

[justinsb]

Works for me :-)

[gambol99]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gambol99

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [gambol99]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[k8s-github-robot]

Automatic merge from submit-queue.

[felipejfc]

is this included in kops 1.8.1? I've just updated a cluster with it and my master's role is yet without DescribeTags

[dobesv]

Seems like this didn't make it into the 1.8 releases of kops, based on what I see in that branch. I am adding that privilege manually but I'm not sure if kops will undo my change later if I update the cluster again.

[dobesv]

Looks like it will roll back the change if I update the cluster again with kops 1.8. However, if I update kops to 1.9 it adds the new permissions when I update my cluster.