Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audit log format flag for api server #4060

Merged

Conversation

audip
Copy link
Contributor

@audip audip commented Dec 13, 2017

In kubernetes 1.8, a flag for audit-log format has been added, this flag can be set to legacy or json format on the kubernetes API server.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 13, 2017
@audip
Copy link
Contributor Author

audip commented Dec 13, 2017

/assign @chrislovecnm

@justinsb
Copy link
Member

Thanks @audip!

You need to run make apimachinery. You also need to add a ` character to the end of the line, so close out the tags. That should make CI happy, and then we can get this merged :-)

@chrislovecnm
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 14, 2017
@audip
Copy link
Contributor Author

audip commented Dec 20, 2017

@justinsb @chrislovecnm updated the PR with a backtick. Is there anything else that is breaking from my PR?

@chrislovecnm
Copy link
Contributor

Yes please run “make apimachinery”

@audip
Copy link
Contributor Author

audip commented Dec 20, 2017

When I ran make apimachinery, it didn't complain or error out.

@chrislovecnm
Copy link
Contributor

You need to check in the new code that is generates.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 21, 2017
@audip
Copy link
Contributor Author

audip commented Dec 21, 2017

@chrislovecnm Added the api machinery code. Sorry, didn't know it was supposed to be added.

@chrislovecnm
Copy link
Contributor

No need to apologize, you mind running

make ci

It will show you that you need to run

make gofmt

@audip audip force-pushed the feature/add-audit-log-format-flag branch from aaf682d to 9900c8a Compare December 21, 2017 17:30
@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit fb6725a into kubernetes:master Dec 21, 2017
@audip
Copy link
Contributor Author

audip commented Feb 22, 2018

@chrislovecnm @justinsb Can we have it added to kops 1.9.0?
This will allow us (Under Armour) to start shipping audit logs in json format to elasticsearch.

@chrislovecnm
Copy link
Contributor

@audip it will be in 1.9 :)

@audip audip deleted the feature/add-audit-log-format-flag branch February 26, 2018 23:09
@justinsb justinsb added this to the 1.9.0 milestone Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants