-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add audit log format flag for api server #4060
Add audit log format flag for api server #4060
Conversation
/assign @chrislovecnm |
Thanks @audip! You need to run |
/ok-to-test |
@justinsb @chrislovecnm updated the PR with a backtick. Is there anything else that is breaking from my PR? |
Yes please run “make apimachinery” |
When I ran |
You need to check in the new code that is generates. |
@chrislovecnm Added the api machinery code. Sorry, didn't know it was supposed to be added. |
No need to apologize, you mind running make ci It will show you that you need to run make gofmt |
aaf682d
to
9900c8a
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
@chrislovecnm @justinsb Can we have it added to kops 1.9.0? |
@audip it will be in 1.9 :) |
In kubernetes 1.8, a flag for audit-log format has been added, this flag can be set to
legacy
orjson
format on the kubernetes API server.