kops validate cluster can output YAML or JSON #4107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
Adding the capbility for kops validate cluster command to output YAML or JSON. The validate.ValidationCluster struct is used as body of the JSON or YAML document.
chrislovecnm
force-pushed
the
validate-ouput
branch
from
d5aaeb1 to
ab4058d
Compare
chrislovecnm
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
| @@ -88,7 +97,9 @@ func RunValidateCluster(f *util.Factory, cmd *cobra.Command, args []string, out | |||
| return fmt.Errorf("cannot get InstanceGroups for %q: %v", cluster.ObjectMeta.Name, err) | |||
| } | |||
|
|
|||
| fmt.Fprintf(out, "Validating cluster %v\n\n", cluster.ObjectMeta.Name) | |||
| if options.output == OutputTable { | |||
There was a problem hiding this comment.
Since this is specific to the OutputTable, does it make sense to move it to its case section of the switch below?
There was a problem hiding this comment.
Well I would have to add it in two places ;(
There was a problem hiding this comment.
yep I see what you mean.
|
lgtm |
|
btw ... it is |
|
/assign @KashifSaadat @andrewsykim @geojaz Whoever gets to it first wins a cookie :) |
|
Tested out, nice work! Where's my cookie? :P |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KashifSaadat The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the capability for kops validate cluster command to output YAML or JSON.
The validate.ValidationCluster struct is used as body of the JSON or
YAML document.
Outputting the list of the node API objects is a bunch of data, but we already have it, and I think
it is useful. It is the same data as
kubectl get no -oyaml. That is the only question I have on this PR if we output that data.Closes #3539
TODO
/assign @robinpercy @robertojrojas
If I can get a PR review that would be awesome.