Extend examples of subnet parameter

[dictvm]

The parameter subnets isn't well named in my opinion. I was expecting it to require the name of a AWS subnet until I checked the configuration of the already existing default-InstanceGroup. Only then I noticed that subnets was meant to be the availability zone or a list of AZs. This change is supposed to make that more obvious.

[chrislovecnm]

/assign @mikesplain

[mikesplain]

Hi @dictvm thanks for the contribution!

The file you changed is actually auto generated by from https://github.com/kubernetes/kops/blob/master/cmd/kops/create_ig.go#L101.

Please follow these steps:

1. Update the go file
2. Run make gen-cli-docs
3. Check in the results

Thanks again!

[mikesplain]

See my note above, thanks for the fix. Take a look in https://github.com/kubernetes/kops/tree/master/docs/development if you need help setting up your development environment or give us a shout here! Thanks again!

[mikesplain]

/area documentation
/ok-to-test

[mikesplain]

@dictvm Any update on this? We always love new contributors so keep us updated! Thanks!

[dictvm]

I'm sorry, I'm not sure if I've done this correctly. I have now updated the docs and the code, tested it locally and I have pushed everything into the branch patch-1. If I had known earlier that the docs are derived from the CLI code, I wouldn't have bothered to just edit the file on Github. Sorry for the confusion, I'll pay more attention next time.

[mikesplain]

@dictvm Hey no worries! Looks good, only issue now is your odd second commit. Would you mind squashing these commits?

[dictvm]

@mikesplain I tried to fix this today, but my git-foo wasn't strong so I ended up with two broken local (detached) branches and merge conflicts. Not sure what went wrong there. I'll try again tomorrow.

I really screwed this up.

[mikesplain]

@dictvm Oh no! That's no fun, remember after rebase you'll have to git push --force to your fork, unless you're using a tool to hide it. Others may have an easier workflow but mine is:

# 2 is the number of commits to modify
git rebase -i @~2
# In the editor swap the second commit from pick to fixup
git push --force <your fork>

[chrislovecnm]

/retest

[dictvm]

Alright, thanks for your help @mikesplain, I hope this is correct now.

[mikesplain]

Thanks @dictvm!
/lgtm

[KashifSaadat]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dictvm, KashifSaadat, mikesplain

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [KashifSaadat]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment