Expose the --fail-swap-on flag for kubelet #4239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @justinsb |
|
Holy crap, we got 2018 all over the place. We should probably break that update into another PR :( |
|
i'll get rid of those pesky 2018's and update this thing |
|
@wannabesrevenge you want to do a 2018 PR? I will merge it quickly. Ping me on Slack if you put it in. |
|
@chrislovecnm can do |
k8s-ci-robot
added
size/M
|
Everything is wrapped and ready for scrutiny |
|
/lgtm |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4123
This change exposes the "--fail-swap-on" flag for kubelet. This means that in the cluster config yaml, you can set
failSwapOn: true | falseunder the kubelet config. More info on this option can be found in the referenced issue (#4123), in the kubernetes docs here, and in the kubernetes github issue here.I made this change by adding the
FailSwapOnfield to the kubelet config structs in the 3 componentconfig.go files. Then I ranmake apimachineryto generate the rest of the changes you see.The changes involving
ImagePullProgressDeadline, reordering some import statements, and changing the copyright to 2018 are the result of runningmake apimachinery. They are unintended. I can undo some or all of these unintended changes if needed.