GCE: Get default project from gcloud CLI #4332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means we don't have to specify a project for the common use case, when gcloud is already configured with a project.
k8s-ci-robot
added
cncf-cla: yes
|
/retest |
cmd/kops/create_cluster.go
Outdated
| if err != nil { | ||
| glog.Warningf("unable to get default google cloud project: %v", err) | ||
| } else if project == "" { | ||
| glog.Warningf("default google cloud project not set") |
There was a problem hiding this comment.
From a ux perspective should we tell them which flag to use? In your words the error could be more actionable. Also this is an error not a warning.
chrislovecnm
approved these changes
Jan 25, 2018
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we don't have to specify a project for the common use case,
when gcloud is already configured with a project.