Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update single-to-multi-master.md #4359

Merged
merged 1 commit into from
Jan 31, 2018
Merged

Update single-to-multi-master.md #4359

merged 1 commit into from
Jan 31, 2018

Conversation

jmthvt
Copy link
Contributor

@jmthvt jmthvt commented Jan 30, 2018 •
edited
Loading

  • Make the distinction between <availability-zone> and <availability-zone-name>, since they can be different (and actually, they are, by default.) it can lead to confusion.
  • Add examples
  • Fix docker stop command

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2018
@jmthvt
Copy link
Contributor Author

jmthvt commented Jan 30, 2018

/assign @justinsb

@mikesplain
Copy link
Contributor

Thanks for the contribution @jeyglk! These look like some solid updates to me.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2018
gzzo
gzzo reviewed Jan 30, 2018
View reviewed changes
docs/single-to-multi-master.md Outdated
@@ -10,6 +10,8 @@ Please follow all the backup steps before attempting it. Please read the
[etcd admin guide](https://github.com/coreos/etcd/blob/v2.2.1/Documentation/admin_guide.md)
before attempting it.

We can migrate from a single-master cluster to a multi-master cluster, but this is a complicated operation. It is easier to create a multi-master cruster using Kops (described [here](https://github.com/kubernetes/kops/blob/master/docs/high_availability.md)). If possible, try to plan this at time of cluster creation.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a typo here "cruster" should be "cluster"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks, corrected

@jmthvt jmthvt force-pushed the feature/single-to-multi-master-doc-improvements branch from 547fadf to d00de67 Compare January 30, 2018 17:14
@k8s-github-robot
Copy link

/lgtm cancel //PR changed after LGTM, removing LGTM. @jeyglk @justinsb @mikesplain

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2018
@mikesplain
Copy link
Contributor

mikesplain commented Jan 30, 2018 •
edited
Loading

Good eye @gzzo. Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2018
chrislovecnm
chrislovecnm approved these changes Jan 31, 2018
View reviewed changes
Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay docs update makes me happy.

docs/single-to-multi-master.md
## 3 - Add a new master

### a - Add a new member to the etcd clusters

**The clusters will stop to work until the new member is started**.

```bash
$ kubectl --namespace=kube-system exec etcd-server-ip-172-20-36-161.ec2.internal -- etcdctl member add etcd-<availability-zone2> http://etcd-<availability-zone2>.internal.example.com:2380
$ kubectl --namespace=kube-system exec etcd-server-events-ip-172-20-36-161.ec2.internal -- etcdctl --endpoint http://127.0.0.1:4002 member add etcd-events-<availability-zone2> http://etcd-events-<availability-zone2>.internal.example.com:2381
$ kubectl --namespace=kube-system exec etcd-server-ip-172-20-36-161.ec2.internal -- etcdctl member add etcd-<availability-zone2-name> http://etcd-<availability-zone2-name>.internal.example.com:2380 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit picks that you can follow up in another or if you like. Looks grear btw

I hate, and I know I have done it before the ‘$’ sign with the prompt makes copy paste a pain.

Can we get the name of the pod via a label? That way we do not have to have a name the is unique in the examples.

@chrislovecnm
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm, jeyglk, mikesplain

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2018
@chrislovecnm
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 31, 2018
@k8s-ci-robot k8s-ci-robot merged commit f58d7b2 into kubernetes:master Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzzo gzzo gzzo left review comments

@chrislovecnm chrislovecnm chrislovecnm approved these changes

Assignees

@justinsb justinsb

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jmthvt @mikesplain @k8s-github-robot @chrislovecnm @k8s-ci-robot @gzzo @justinsb