Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

master node requires DescribeRegions when using a bucket from another… #4409

Merged
merged 3 commits into from
Feb 12, 2018
Merged

master node requires DescribeRegions when using a bucket from another… #4409

merged 3 commits into from
Feb 12, 2018

Conversation

sstarcher
Copy link
Contributor

… account

fixes #4408

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2018
@sstarcher
Copy link
Contributor Author

/assign @chrislovecnm

@chrislovecnm
Copy link
Contributor

Do we need this on the nodes as well? And ci is failing.

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 8, 2018
@sstarcher
Copy link
Contributor Author

The nodes already have DescribeRegions

@sstarcher
Copy link
Contributor Author

/retest

1 similar comment
@sstarcher
Copy link
Contributor Author

/retest

@sstarcher
Copy link
Contributor Author

@chrislovecnm hmm as I thought the e2e failed twice randomly, but the third attempt worked. I was shocked my change could have any effect on the e2e.

@mikesplain
Copy link
Contributor

@sstarcher Looks like it was probably flakey.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2018
@KashifSaadat
Copy link
Contributor

Thanks @sstarcher :)

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KashifSaadat, mikesplain, sstarcher

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit 39e2530 into kubernetes:master Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chrislovecnm chrislovecnm

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nodeup on master fails when s3 bucket is in a different region
5 participants
@sstarcher @chrislovecnm @mikesplain @KashifSaadat @k8s-ci-robot