Bazel docker, cross builds and uploading to s3 #4477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
Moving this to 1.9.1 because I don't want it to block 1.9.0, not that we can't merge when it's ready :-) |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm cancel //PR changed after LGTM, removing LGTM. @mikesplain @robinpercy |
k8s-github-robot
removed
the
lgtm
|
Wahoo, they pushed new rules_go so I added that for now, for testing purposes. |
mikesplain
force-pushed
the
bazel_images_make
branch
from
8431d17 to
f0ad5ed
Compare
k8s-ci-robot
added
size/S
Tested all of these on each of their systems Need more real testing to ensure all issues are fixed but worked better than not for me
k8s-ci-robot
added
size/M
mikesplain
force-pushed
the
bazel_images_make
branch
from
c223b28 to
7f139ca
Compare
mikesplain
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
| bazel build --experimental_platforms=@io_bazel_rules_go//go/toolchain:linux_amd64 //images:dns-controller.tar | ||
|
|
||
| .PHONY: bazel-crossbuild-protokube-image | ||
| bazel-crossbuild-protokube-image: |
There was a problem hiding this comment.
Got a odd warning here:
WARNING: /private/var/tmp/_bazel_clove/8fb6d18c232e3eae2b829c764cbc089c/external/distroless_rules/WORKSPACE:1: Workspace name in
/private/var/tmp/_bazel_clove/8fb6d18c232e3eae2b829c764cbc089c/external/distroless_rules/WORKSPACE (@distroless) does not match the name given in the repository's definition (@distroless_rules); this will cause a build error in future versions
|
Nice work!!! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, mikesplain, robinpercy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr includes some updates to bazel building docker images, bazel cross builds, and uploading to s3. From what I can tell, you can now do
make bazel-uploadand things work end to end as they would withmake upload.I kept bazel-upload, etc. separate since I didn't want to change any existing build stuff, though this should certainly be refactored.
This also pulls in distroless_rules and debian stretch package management utils to build the protokube container with bazel. I'm not sure if this is 100% what we should do but it works well in dev from my testing.
Bazel version 0.10.0
Comments/suggestions welcome!