Use k8s.gcr.io alias only for 1.10 #4494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
@justinsb Do you have any ETA for that to be merged? |
justinsb
force-pushed
the
gcr_alias_only_for_1_10
branch
from
70a4b01 to
cfa1cc4
Compare
mikesplain
reviewed
Feb 22, 2018
There was a problem hiding this comment.
This looks good to me assuming you get the 2 etcd tests fixed @justinsb
| // and we only double-tag from 1.10 onwards. | ||
| // For versions prior to 1.10, remap k8s.gcr.io to the old name. | ||
| // This also means that we won't start using the aliased names on existing clusters, | ||
| // which could otherwise be surprising to users. |
There was a problem hiding this comment.
Love this comment, thanks for the explanation.
|
@wojtek-t I just pinged @justinsb about the broken tests, but once those are fixed @mikesplain or I can lgtm |
|
/assign |
**Why:** * The current logo is using the block type logo, this updates to the smile logo **This change addresses the need by:** * closes kubernetes#4480 Signed-off-by: Christopher Hein <[email protected]>
The k8s.gcr.io prefix is an alias, but for CI builds we run from a docker load, and we only double-tag from 1.10 onwards. For versions prior to 1.10, remap k8s.gcr.io to the old name. This also means that we won't start using the aliased names on existing clusters, which could otherwise be surprising to users.
justinsb
force-pushed
the
gcr_alias_only_for_1_10
branch
from
cfa1cc4 to
c74f956
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The k8s.gcr.io prefix is an alias, but for CI builds we run from a
docker load, and we only double-tag from 1.10 onwards. For versions
prior to 1.10, remap k8s.gcr.io to the old name. This also means that
we won't start using the aliased names on existing clusters, which could
otherwise be surprising to users.