-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node monitor flags #4525
Add node monitor flags #4525
Conversation
/assign @geojaz I'm not sure what else I need to do for this change? |
Take a look at https://github.com/kubernetes/kops/blob/master/docs/development/api_updates.md You need to update the two other files and generate the code with apimachinery |
should I create a separate PR for adding terminated pods garbage collection flags for controller manager - see: evicted pods issue EDIT: just noticed it's already there - sorry |
@chrislovecnm let me know if I missed anything out |
/ok-to-test |
This looks good, I am checking to see if we are still merging code since we are close to the 1.9 release |
maybe I should add docs on how to apply what's in the article (or I can do this in a separate PR?) |
/lgtm No user-facing impact => ok to merge :-) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, so0k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To improve quicker detection of a node being down, allow users to set
node-status-update-frequency
flagnode-monitor-*
andpod-eviction-timeout
flagsRef Improving Kubernetes reliability: quicker detection of a node down