Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kube Proxy IPVS Kernel Module #4550

Merged
merged 1 commit into from
Mar 2, 2018
Merged

Kube Proxy IPVS Kernel Module #4550

merged 1 commit into from
Mar 2, 2018

Conversation

gambol99
Copy link
Contributor

@gambol99 gambol99 commented Mar 1, 2018 •
edited
Loading

before

[ep-acp-jest@acp] (master) $ kubectl -n kube-system logs kube-proxy-ip-10-250-100-55.eu-west-2.compute.internal
Flag --resource-container has been deprecated, This feature will be removed in a later release.
W0301 21:18:44.695034       1 server.go:191] WARNING: all flags other than --config, --write-config-to, and --cleanup are deprecated. Please begin using a config file ASAP.
I0301 21:18:44.697585       1 iptables.go:192] Could not connect to D-Bus system bus: dial unix /var/run/dbus/system_bus_socket: connect: no such file or directory
time="2018-03-01T21:18:44Z" level=warning msg="Running modprobe ip_vs failed with message: `modprobe: ERROR: ../libkmod/libkmod.c:557 kmod_search_moddep() could not open moddep file '/lib/modules/4.14.16-coreos/modules.dep.bin'`, error: exit status 1"
time="2018-03-01T21:18:44Z" level=error msg="Could not get ipvs family information from the kernel. It is possible that ipvs is not enabled in your kernel. Native loadbalancing will not work until this is fixed."
W0301 21:18:44.702918       1 server_others.go:268] Flag proxy-mode="" unknown, assuming iptables proxy

after

core@ip-10-250-31-251 /etc/kubernetes/manifests $ docker logs 473e93f69cac
Flag --resource-container has been deprecated, This feature will be removed in a later release.
W0301 21:43:18.106609       1 server.go:191] WARNING: all flags other than --config, --write-config-to, and --cleanup are deprecated. Please begin using a config file ASAP.
I0301 21:43:18.109131       1 iptables.go:192] Could not connect to D-Bus system bus: dial unix /var/run/dbus/system_bus_socket: connect: no such file or directory
W0301 21:43:18.277882       1 server_others.go:268] Flag proxy-mode="" unknown, assuming iptables proxy
I0301 21:43:18.279494       1 server_others.go:122] Using iptables Proxier.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 1, 2018
@gambol99
Copy link
Contributor Author

gambol99 commented Mar 1, 2018

fixed the issues raised in #4544

@gambol99
Copy link
Contributor Author

gambol99 commented Mar 1, 2018

/assign @chrislovecnm

@chrislovecnm
Copy link
Contributor

@robinpercy you mind?

robinpercy
robinpercy reviewed Mar 2, 2018
View reviewed changes
nodeup/pkg/model/kube_proxy.go Outdated
@@ -204,6 +204,7 @@ func (b *KubeProxyBuilder) buildPod() (*v1.Pod, error) {
{
addHostPathMapping(pod, container, "kubeconfig", "/var/lib/kube-proxy/kubeconfig")
addHostPathMapping(pod, container, "logfile", "/var/log/kube-proxy.log").ReadOnly = false
addHostPathMapping(pod, container, "modules", "/lib/modules")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gambol99 I think we should add a comment as well. The reason for this mapping is less obvious than the other two.

Copy link
Contributor Author

@gambol99 gambol99 Mar 2, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, make's sense .. I've added a note

@robinpercy
Copy link
Contributor

Requested a comment, but otherwise /lgtm

@gambol99
Kube Proxy IPVS Kernel Module
23f9c63 
- fixing the the 'Could not get ipvs family information from the kernel. It is possible that ipvs is not enabled in your kernel. Native loadbalancing will not work until this is fixed.' error
@robinpercy
Copy link
Contributor

Thanks @gambol99
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gambol99, robinpercy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 27852b0 into kubernetes:master Mar 2, 2018
@gambol99 gambol99 mentioned this pull request Mar 2, 2018
Closed
@kumudt
Copy link

kumudt commented Mar 19, 2018 •
edited
Loading

Can this be cherry-picked to 1.8.x as well??
Facing the same issue with kops 1.8.1 and Kubernetes 1.8.9

@gambol99 gambol99 deleted the kube_proxy_ipvs branch February 21, 2019 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinpercy robinpercy robinpercy left review comments

@KashifSaadat KashifSaadat KashifSaadat approved these changes

Assignees

@robinpercy robinpercy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gambol99 @chrislovecnm @robinpercy @k8s-ci-robot @kumudt @KashifSaadat