add system:masters group to admin user in static token file #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… basic auth. this should fix kubernetes#4369
k8s-ci-robot
added
cncf-cla: yes
|
/assign @justinsb |
|
/ok-to-test Will have @justinsb look at this one, as it is delving into auth that I am not familiar with. |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/lgtm /approve Thanks @erks |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erks, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #4369
Tested using the dev version of
nodeup:adminuser in/srv/kubernetes/known_tokens.csvnow has thesystem:mastersgroup# grep admin /srv/kubernetes/known_tokens.csv 0ODfxv1qwwzDwOmqTnyHTLkDZ0uwC1GZ,admin,admin,system:masterskubernetes-dashboard(created with the default--authentication-mode=token) now has full access