Fix routetable detection #4661
Merged
Fix routetable detection #4661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
approved
justinsb
force-pushed
the
fix_routetable
branch
from
8c2f42a to
88f334c
Compare
justinsb
force-pushed
the
fix_routetable
branch
from
88f334c to
6b97c27
Compare
k8s-ci-robot
added
the
needs-rebase
This enables the non-legacy shared tags.
Once we dropped the Name tag,we have no way to find RouteTables otherwise.
Should be equivalent, but a little more correct.
justinsb
force-pushed
the
fix_routetable
branch
from
6b97c27 to
785cc81
Compare
k8s-ci-robot
added
size/XL
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem we have to solve is that when we do a shared RouteTable, if we don't specify the Name, then we have no way to identify it.
Instead we introduce a role tag, and we can identify it by the shared cluster tag with the role tag.