Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kube-dns to 1.14.9 #4851

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Update kube-dns to 1.14.9 #4851

merged 1 commit into from
Apr 9, 2018

Conversation

sergeylanzman
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 1, 2018
@justinsb
Copy link
Member

justinsb commented Apr 1, 2018

/ok-to-test

This is tricky though, because this only merged into k8s a few days ago, and hasn't yet been backported even to 1.10: kubernetes/kubernetes@af84698

On the other hand, this looks good:

  • Fix for kube-dns returns NXDOMAIN when not yet synced with apiserver

Is there any compelling reason to justify an immediate update @sergeylanzman ? Otherwise I propose we wait for kops 1.10, which we are aiming to release around the end of April (and we're going to cut 1.10 alpha.1 with the release of kops 1.9)

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 1, 2018
@justinsb justinsb added this to the 1.10 milestone Apr 1, 2018
@sergeylanzman
Copy link
Contributor Author

@justinsb
I need this fix kubernetes/dns#210
but I can wait to end of April(update kube-dns manually)

@justinsb
Copy link
Member

justinsb commented Apr 9, 2018

It's been cherry picked, so

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, sergeylanzman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2018
@k8s-ci-robot k8s-ci-robot merged commit a8ca362 into kubernetes:master Apr 9, 2018
@ApsOps
Copy link
Contributor

ApsOps commented Apr 13, 2018 •
edited
Loading

I think this has broken the resolution of externalName services for us. :/

Issue created here - kubernetes/dns#224

@FrederikNJS FrederikNJS mentioned this pull request Apr 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.
4 participants
@sergeylanzman @justinsb @k8s-ci-robot @ApsOps