digitalocean: list/delete resources #4916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
andrewsykim
force-pushed
the
digitalocean-resources
branch
2 times, most recently
from
47dcb0b to
a92a560
Compare
andrewsykim
force-pushed
the
digitalocean-resources
branch
from
a92a560 to
6831bd8
Compare
justinsb
reviewed
Apr 5, 2018
| } | ||
|
|
||
| for _, volume := range volumes { | ||
| if strings.Contains(volume.Name, volumeMatch) { |
|
One question about whether you want to use Contains or HasPrefix when matching volumes, but lgtm /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Left out list/delete for DNS since I'm thinking of adopting external-dns.
#2150