Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo fix an->and #4930

Merged
merged 1 commit into from
Apr 7, 2018
Merged

Typo fix an->and #4930

merged 1 commit into from
Apr 7, 2018

Conversation

AdamDang
Copy link
Contributor

@AdamDang AdamDang commented Apr 6, 2018

Line 119: "kubectl is downloaded an installed by other tasks"
Typo fix an->and

@AdamDang
Typo fix an->and
71d8d23 
Typo fix an->and
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 6, 2018
@AdamDang
Copy link
Contributor Author

AdamDang commented Apr 6, 2018

/assign @justinsb

@mikesplain
Copy link
Contributor

Thanks @AdamDang

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 6, 2018
@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2018
@chrislovecnm
Copy link
Contributor

/lgtm

Let me know if you want to work on writing more docs, like new ones. Appreciate the spelling fixes.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AdamDang, chrislovecnm, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 243ee7c into kubernetes:master Apr 7, 2018
@AdamDang
Copy link
Contributor Author

AdamDang commented Apr 7, 2018

@chrislovecnm
Thanks for your invitation! I'd like to work on the document. I can try a new one.

@AdamDang AdamDang deleted the patch-15 branch May 1, 2018 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrislovecnm chrislovecnm chrislovecnm approved these changes

Assignees

@justinsb justinsb

@chrislovecnm chrislovecnm

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AdamDang @mikesplain @chrislovecnm @k8s-ci-robot @justinsb