implement scalingGroup tasks for AliCloud #5341
Conversation
k8s-ci-robot
added
cncf-cla: yes
Lily922
force-pushed
the
scalingGroup
branch
2 times, most recently
from
29d3ab1 to
2511646
Compare
| // Disable ScalingGroup, used to bind scalingConfig, we should excute EnableScalingGroup in the task LaunchConfiguration | ||
| // If the ScalingGroup is active, we can not excute EnableScalingGroup. | ||
| if e.ScalingGroup.Active != nil && fi.BoolValue(e.ScalingGroup.Active) { | ||
|
|
There was a problem hiding this comment.
Should we be looking here at a, not e? I think we're disabling the existing scaling group?
There was a problem hiding this comment.
@justinsb We will not create a new scaling group when 'update', we just create a new configuration for the old scaling group, so both 'a' and 'e' will have the correct id of exiting scaling group. But use 'a' will be more reasonable here, I will remember this tip. Thank you very much for your instant review of the codes.
|
One query about the launch configuration update, but looks good /approve |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, LilyFaFa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This is part of #4127.