Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed duplicate info #5425

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Fixed duplicate info #5425

merged 1 commit into from
Oct 8, 2018

Conversation

marceliwac
Copy link
Contributor

Fixed duplicate info about default value for --topology flag

Fixed duplicate info about default value for --topology flag
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marceliwac
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: chrislovecnm

If they are not already assigned, you can assign the PR to them by writing /assign @chrislovecnm in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marceliwac
Copy link
Contributor Author

CLA verification check

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 10, 2018
@marceliwac
Copy link
Contributor Author

/assign @chrislovecnm

@mikesplain
Copy link
Contributor

mikesplain commented Jul 10, 2018

Hi @marceliwac! Thanks for the contribution! That's a great find, we definitely should get that cleaned up.

Those docs are actually autogenerated from here:

cmd.Flags().StringVarP(&options.Topology, "topology", "t", options.Topology, "Controls network topology for the cluster. public|private. Default is 'public'.")

Mind making the change there as well? It also looks like we have the same thing for the dns flag:

cmd.Flags().StringVar(&options.DNSType, "dns", options.DNSType, "DNS hosted zone to use: public|private. Default is 'public'.")

To make those changes:

  1. Clone the repo locally
  2. Make the changes to the go file
  3. run make gen-api-docs
  4. checkin the resulting code.

Let me know if you need any further help!

/area documentation
/ok-to-test

@k8s-ci-robot k8s-ci-robot added area/documentation and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2018
@mikesplain
Copy link
Contributor

/assign
/unassign @chrislovecnm

(unassigning Chris till things are good to go!)

@justinsb justinsb added this to the 1.11 milestone Jul 18, 2018
@mikesplain
Copy link
Contributor

Hi @marceliwac any update on this?

@justinsb
Copy link
Member

justinsb commented Oct 8, 2018

Going to force-merge and then submit the source change. Thanks for spotting @marceliwac !

@justinsb justinsb merged commit b1db2f3 into kubernetes:master Oct 8, 2018
justinsb added a commit to justinsb/kops that referenced this pull request Oct 8, 2018
Follow on to kubernetes#5425; another flag and we need to update the source code
as well as the output.
@justinsb
Copy link
Member

justinsb commented Oct 8, 2018

Follow on is #5896

justinsb added a commit to justinsb/kops that referenced this pull request Oct 8, 2018
Follow on to kubernetes#5425; another flag and we need to update the source code
as well as the output.
justinsb added a commit to justinsb/kops that referenced this pull request Oct 8, 2018
Follow on to kubernetes#5425; another flag and we need to update the source code
as well as the output.
justinsb added a commit to justinsb/kops that referenced this pull request Oct 9, 2018
Follow on to kubernetes#5425; another flag and we need to update the source code
as well as the output.

Follow on also to kubernetes#5721 and kubernetes#4687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants