-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed duplicate info #5425
Fixed duplicate info #5425
Conversation
Fixed duplicate info about default value for --topology flag
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: marceliwac If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CLA verification check |
/assign @chrislovecnm |
Hi @marceliwac! Thanks for the contribution! That's a great find, we definitely should get that cleaned up. Those docs are actually autogenerated from here: kops/cmd/kops/create_cluster.go Line 313 in 617ce04
Mind making the change there as well? It also looks like we have the same thing for the dns flag: kops/cmd/kops/create_cluster.go Line 319 in 617ce04
To make those changes:
Let me know if you need any further help! /area documentation |
/assign (unassigning Chris till things are good to go!) |
Hi @marceliwac any update on this? |
Going to force-merge and then submit the source change. Thanks for spotting @marceliwac ! |
Follow on to kubernetes#5425; another flag and we need to update the source code as well as the output.
Follow on is #5896 |
Follow on to kubernetes#5425; another flag and we need to update the source code as well as the output.
Follow on to kubernetes#5425; another flag and we need to update the source code as well as the output.
Follow on to kubernetes#5425; another flag and we need to update the source code as well as the output. Follow on also to kubernetes#5721 and kubernetes#4687
Fixed duplicate info about default value for --topology flag