-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme compatability matrix for 1.10 #5484
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know the README says
kops is intended to be backward compatible.
but is there a point where we would no longer support a older version of k8s with the newest version of Kops? The idea behind that being that we would then be able to clean up older code. I've also not see anyone testing the older versions (such as 1.5.x) so new code may not actually support those versions?Just a passing thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a balance between the cost of carrying the old branches vs breaking people's clusters (even if those clusters are running versions of k8s that are unsupported).
So far the cost hasn't been too high, but if we came to a point where the cost was high I could see that we would start a deprecation procedure or tell people that they had to use an older version of kops and that they wouldn't be getting bugfixes.
As you say though, it's certainly not a good idea to run e.g. k8s 1.5 with kops today, because it doesn't have nearly the same testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree both thoughts. I think the readme isn't the right place to begin considering this as it takes more time to denote deprecation and decide the course of action.
I've opened an issue to track and figure out if and how we should consider this.
Thanks @justinsb and @rdrgmnzs!