Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

one word change to docs grammar tense issue ran -> run #5546

Merged
merged 1 commit into from
Jul 29, 2018
Merged

one word change to docs grammar tense issue ran -> run #5546

merged 1 commit into from
Jul 29, 2018

Conversation

ms4720
Copy link
Contributor

@ms4720 ms4720 commented Jul 28, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 28, 2018
@ms4720
Copy link
Contributor Author

ms4720 commented Jul 28, 2018

@justinsb new pull, hope it goes better

@ms4720
Copy link
Contributor Author

ms4720 commented Jul 28, 2018

/assign @justinsb

@chrisz100
Copy link
Contributor

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 28, 2018
@ms4720
Copy link
Contributor Author

ms4720 commented Jul 29, 2018

in my previous attempt to get this merged, #5538 , the cncf-cla: yes label was added quickly. Is there a reason it is not showing up now?

@chrisz100
Copy link
Contributor

Possibly the bot missed adding it - also as both you and justin added commits...
/check-cla

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2018
@chrisz100
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2018
@mikesplain
Copy link
Contributor

Thanks @ms4720!

/area documentation
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, mikesplain, ms4720

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2018
@k8s-ci-robot k8s-ci-robot merged commit 5fe9c6d into kubernetes:master Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

@chrisz100 chrisz100

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ms4720 @chrisz100 @mikesplain @k8s-ci-robot @justinsb