Fix interactive rolling update silently ignored #5642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/rolling-update
needs-ok-to-test
Mikulas
changed the title
Updated to use same logic as DeleteInstance does: print at least the host id as that is always available and only include node name if set.
Mikulas
force-pushed
the
cloudonly-interactive
branch
from
009c039 to
525c0a9
Compare
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Thanks @Mikulas /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisz100, justinsb, Mikulas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves on #4166 (Interactive cli opt) by adding
--interactivesupport for rolling updates in--cloudonlymode and for feature flagDrainAndValidateRollingUpdatedisabled. Without this fix, the interactive flag is silently ignored.Why is this change needed: it's not currently obvious the interactive mode does not always work. Also, I'd say interactive rolling update is most useful when the validation is turned off or the upgrade is cloud only.
Originally there were four (!) cases with only the penultimate one using the interactive prompt:
This PR only adds the prompt after removing any cluster node. Bastion nodes still do not prompt.
As for the implementation:
continueafter bastion upgrade to not trigger the prompt.DeleteInstancemethodTests: there were no tests in the original pr #4166 and I'm not quite sure how to test this on CI. I've run the upgrade locally though and the command works as expected.
/area rolling-update