-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typo fixes in stable for ci verify jobs #5737
Conversation
@chrisz100 do we know if the CI job will just fix these once again? |
What do you mean fix these? As it’s just the last release and we don’t replicate this in the next release (my commit message is spelled correctly) that should be fine |
@chrisz100 I'm wondering if the CI bot will revert your fixes in the 1.10 changelog. |
Highly doubt that but possibly @justinsb knows more about these scripts? |
Hmm well these aren't really typos since they are the actual commit message and are the actual change. The CI just runs |
I don’t remember the PR ids but it’s been in quite a few pull requests. |
This looks like a good way to fix this - thanks! I'm looking at our verify-spelling script in more detail as well now - we were pulling from github, and it's better to vendor, so tackling that. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisz100, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The changelog for 1.10 includes typos our vetting now marks as a bug. Cleaned the typos and annotated where something was modified in 1.10 release notes.