-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update k8s-ec2-srcdst to v0.2.2 #5746
Update k8s-ec2-srcdst to v0.2.2 #5746
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
cefc0d5
to
9940045
Compare
/assign @chrislovecnm |
/ok-to-test |
/retest
…---- On Tue, 04 Sep 2018 21:15:32 +1000 [email protected] wrote ----
@willthames: The following test failed, say /retest to rerun them all:
Test name Commit Details Rerun command
pull-kops-e2e-kubernetes-aws 9940045 link /test pull-kops-e2e-kubernetes-aws
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This should also fix #4466 |
Thanks @willthames for this, getting this fixed would be great. In order for any of these changes to be picked up you'll need to version bump the manifest here (e.g.
Mind making that change in the same single commit as above so it's easily traceable what the change was? Thanks! |
/assign |
v0.2.2 fixes a bug where k8s-ec2-srcdst can crash on node deletion. This crash causes SourceDestinationCheck to remain set to true on nodes created after this check. Such nodes cannot talk to calico destinations in the *same* subnet. Fixes kubernetes/kubernetes#66432
9940045
to
142d71f
Compare
@mikesplain done |
Great thanks so much @willthames! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisz100, mikesplain, willthames The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @mikesplain - do you know when this will get into a 1.10 release? |
I’m not sure, we’re working on increasing the frequency of releases. It will certainly be in 1.11 alpha. In the meantime you can certainly use our makefile to build just the cli, it should work without building additional components for the time being. |
v0.2.2 fixes a bug where k8s-ec2-srcdst can crash on node deletion.
This crash causes SourceDestinationCheck to remain set to true on
nodes created after this check. Such nodes cannot talk to calico
destinations in the same subnet.
Fixes kubernetes/kubernetes#66432