-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cni toleration for tainted nodes #5804
Cni toleration for tainted nodes #5804
Conversation
/ok-to-test |
/lgtm Thank you for fixing this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this @jhohertz! For these changes to get picked up, you'll have to bump the version here as well:
version := "1.0.0-kops.1" |
(bump the .1 to .2) and also bump for cilium as well in the same manor. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks @jhohertz!
/lgtm
/approve
Oops, looks like you'll have to update the test as well:
|
Thanks for helping me through this first PR. :) |
No worries! A pleasure :-) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisz100, jhohertz, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Related to #5730, replaces #5802 (mistakenly issued against release-1.10 branch)
This increases the tolerations for the two CNIs in the subject to allow them to deploy/work on clusters with instance groups that have a taint to them.
Note: I've not been able to test this in a build due to other apparent issues in the build (I am new to this codebase), but have verified that patching these manifests after the fact addresses the stated issue.
As mentioned in the other ticket, this is very similar changes made for other CNI providers as follows:
Canal: #3802, #3142
Calico: #3097