-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Weave Net to version 2.4.1 #5845
Conversation
Includes bug fixes to the deleted-node cleanup code. Release notes https://github.com/weaveworks/weave/releases/tag/v2.4.1 Signed-off-by: Bryan Boreham <[email protected]>
Hi @bboreham, thanks for the PR! I'm not sure if we can consider the bugs fixed as users are reporting them as not fixed as in weaveworks/weave#3300 . I will ran the tests again next week and report here to see if we should go on integrating this PR or wait for additional fixes. |
Those users are talking about a minor issue causing nothing more than some noise in the logs. |
Thanks for the clarifications.
I will test this with one of my kops cluster and give an update here.
…On Sat, Oct 6, 2018, 18:09 Bryan Boreham ***@***.***> wrote:
Those users are talking about a minor issue causing nothing more than some
noise in the logs.
This is trivial compared to the race conditions that were fixed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5845 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AApv1DaPrh5tscsGiMtxovTuldVZ1h2eks5uiNWsgaJpZM4W-QA4>
.
|
Thanks @bboreham - we need to bump the version in bootstrapchannelbuilder also, but I'll send a PR to do that /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bboreham, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this PR a candidate for cherry-pick for a kops 1.10.1 version ? |
Includes bug fixes to the deleted-node cleanup code. Those bugs have hit people with auto-scaling groups that go up and down - definitely a recommended update in this case.
Release notes https://github.com/weaveworks/weave/releases/tag/v2.4.1