#5700: Add command line flag for disabling Subnet ELB tags #5875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
seanson
force-pushed
the
5700_add_flag_for_no_subnet_tags
branch
from
e0a906e to
ca073d0
Compare
seanson
changed the title
|
/assign @andrewsykim |
k8s-ci-robot
added
the
needs-rebase
seanson
force-pushed
the
5700_add_flag_for_no_subnet_tags
branch
from
ca073d0 to
737a7a2
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/lgtm |
k8s-ci-robot
added
the
lgtm
mikesplain
approved these changes
Nov 9, 2018
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisz100, mikesplain, seanson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix/improvement for issue #5700.
The current actual kops behavior is to tag shared subnets, but the documentation refers to having to manage your own tags. I feel it is best to keep the current subnet tagging behavior and add a toggle to disable. This will keep user experience standard by creating working clusters when using existing subnets but also allows power users to manually manage tags if they wish. Manual management of tags allows things like using separate dedicated subnets for internal ingress.