Disable RBAC Addon's in Node Mode #5925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation applys the rbac addons regardless. When node authorization is enable this manifests is skipped. In regard to rollouts from RBAC -> Node, the process will be disable manifest, though the clusterrolebindings will still exist. Once all the nodes have been upgraded to use Node authorization the administrator can delete the binding maunally.
k8s-ci-robot
added
cncf-cla: yes
|
/assign @justinsb |
| { | ||
| key := "rbac.addons.k8s.io" | ||
| version := "1.8.0" | ||
| // @check if node authorization or bootstrap tokens are enabled an if so we can forgo applying |
|
Looks good, will wait for another set of eyes to approve :) |
|
/lgtm Looks good for me as well! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisz100, gambol99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation applys the rbac addons regardless. When node authorization or bootstrap token are enabled this manifests is skipped. In regard to rollouts from RBAC -> Node, the process will be disable manifest, though the clusterrolebindings will remain. Once all the nodes have been upgraded to use Node authorization the administrator can delete the binding manually. As indicated by https://kubernetes.io/docs/reference/access-authn-authz/node/