Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always create /var/lib/kubelet, even in bootstrap mode #5982

Merged
merged 1 commit into from
Mar 17, 2019

Conversation

justinsb
Copy link
Member

Otherwise we end up with a circular dependency where we don't run the
node-authorizer until /var/lib/kubelet has been bind-mounted, but it
can't be bind-mounted until it exists.

This bind-mounting happens on Google's ContainerOS, which is why it
isn't always seen.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 21, 2018
@chrisz100
Copy link
Contributor

/lgtm

It can be so simple to stop crazy things from happening 🤟🏼

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2018
@justinsb justinsb force-pushed the create_var_lib_kubelet branch from 5458438 to d7ae45a Compare October 21, 2018 18:39
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2018
@justinsb
Copy link
Member Author

/retest

Doesn't look entirely unrelated - mount propagation in /var/lib/kubelet. Maybe the file mode. Retesting to get more signal...

@gambol99
Copy link
Contributor

/test pull-kops-e2e-kubernetes-aws

@justinsb justinsb force-pushed the create_var_lib_kubelet branch from d7ae45a to af7a6e5 Compare November 9, 2018 05:41
@justinsb
Copy link
Member Author

justinsb commented Nov 9, 2018

Changing the directory mode to 755 - I'm guessing the permissions were causing the mount propagation errors.

@justinsb
Copy link
Member Author

justinsb commented Nov 9, 2018

/retest

The zone selection fix merged in test-infra, just checking if it's live...

@justinsb justinsb added this to the 1.12 milestone Nov 10, 2018
@justinsb
Copy link
Member Author

Moving to 1.12 milestone - no need for this in 1.11 I don't think

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 9, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 11, 2019
Otherwise we end up with a circular dependency where we don't run the
node-authorizer until /var/lib/kubelet has been bind-mounted, but it
can't be bind-mounted until it exists.

This bind-mounting happens on Google's ContainerOS, which is why it
isn't always seen.
@justinsb justinsb force-pushed the create_var_lib_kubelet branch from af7a6e5 to ecbc341 Compare March 14, 2019 05:08
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrisz100
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3b907c8 into kubernetes:master Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants