-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always create /var/lib/kubelet, even in bootstrap mode #5982
Always create /var/lib/kubelet, even in bootstrap mode #5982
Conversation
/lgtm It can be so simple to stop crazy things from happening 🤟🏼 |
5458438
to
d7ae45a
Compare
/retest Doesn't look entirely unrelated - mount propagation in /var/lib/kubelet. Maybe the file mode. Retesting to get more signal... |
/test pull-kops-e2e-kubernetes-aws |
d7ae45a
to
af7a6e5
Compare
Changing the directory mode to 755 - I'm guessing the permissions were causing the mount propagation errors. |
/retest The zone selection fix merged in test-infra, just checking if it's live... |
Moving to 1.12 milestone - no need for this in 1.11 I don't think |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Otherwise we end up with a circular dependency where we don't run the node-authorizer until /var/lib/kubelet has been bind-mounted, but it can't be bind-mounted until it exists. This bind-mounting happens on Google's ContainerOS, which is why it isn't always seen.
af7a6e5
to
ecbc341
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Otherwise we end up with a circular dependency where we don't run the
node-authorizer until /var/lib/kubelet has been bind-mounted, but it
can't be bind-mounted until it exists.
This bind-mounting happens on Google's ContainerOS, which is why it
isn't always seen.