Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stdin input for secrets #5993

Merged
merged 1 commit into from
Oct 27, 2018
Merged

Add stdin input for secrets #5993

merged 1 commit into from
Oct 27, 2018

Conversation

ihoegen
Copy link
Contributor

@ihoegen ihoegen commented Oct 23, 2018

This PR allows for stdin input for creating kops secrets.

Now where a secret can be created via file, it can be created via stdin.

Example:

encryption-config-generator.sh | kops create encryptionconfig -f -

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2018
@chrisz100
Copy link
Contributor

Good stuff, thanks!
I’d say wait for 1.12 though as it’s touching base components that could break our stable release?
/lgtm
/assign @justinsb

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2018
@justinsb
Copy link
Member

We've cut the 1.11 release branch, so we can cherry-pick selectively if we want to. But I don't think it's that risky - but maybe I'll live to regret that!

Thanks @ihoegen

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, ihoegen, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2018
k8s-ci-robot added a commit that referenced this pull request Oct 27, 2018
Add stdin input for secrets
@k8s-ci-robot k8s-ci-robot merged commit 50531c2 into kubernetes:master Oct 27, 2018
@k8s-ci-robot k8s-ci-robot merged commit 312813e into kubernetes:master Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants