Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #6017

Merged
merged 1 commit into from
Mar 15, 2019
Merged

fix typo #6017

merged 1 commit into from
Mar 15, 2019

Conversation

zqm19941101
Copy link
Contributor

kublet->kubelet

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 30, 2018
@zqm19941101
Copy link
Contributor Author

/assign @mikesplain

@chrisz100
Copy link
Contributor

/ok-to-test
/lgtm

Thanks! :-)

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 30, 2018
@mikesplain
Copy link
Contributor

Thanks for this @zqm19941101! This is a generated file and there's a number of other occurrences of it. Would you mind adding those to this PR? Thanks so much!

kops/pkg/apis/kops/componentconfig.go

Line 80 in 2702b12

// configureCBR0 enables the kublet to configure cbr0 based on Node.Spec.PodCIDR.

kops/pkg/apis/kops/v1alpha1/componentconfig.go

Line 80 in 2702b12

// configureCBR0 enables the kublet to configure cbr0 based on Node.Spec.PodCIDR.

kops/pkg/apis/kops/v1alpha2/componentconfig.go

Line 80 in 2702b12

// configureCBR0 enables the kublet to configure cbr0 based on Node.Spec.PodCIDR.

kops/docs/apireference/build/index.html

Line 3258 in 2702b12

<td>configureCBR0 enables the kublet to configure cbr0 based on Node.Spec.PodCIDR.</td>

https://github.com/kubernetes/kops/blob/2702b12f2b2a77ef9acfbd14064810c04d48bf94/pkg/openapi/openapi_generated.go#L28309

https://github.com/kubernetes/kops/blob/2702b12f2b2a77ef9acfbd14064810c04d48bf94/pkg/openapi/openapi_generated.go#L32915

@zqm19941101
Copy link
Contributor Author

@mikesplain
Don't mind

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 9, 2019
@justinsb
Copy link
Member

Let's just merge!

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, zqm19941101

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit e39a093 into kubernetes:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisz100 chrisz100 Awaiting requested review from chrisz100

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@justinsb justinsb

@chrisz100 chrisz100

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. waiting-for-input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zqm19941101 @chrisz100 @mikesplain @fejta-bot @justinsb @k8s-ci-robot