-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set a dateformat
on logrotate configs on CoreOS
#6059
Conversation
On CoreOS Container Linux, `dateext` is set, which causes log rotation based on maxsize to not run, when a previous rotation already happened on the calendar same day. (cherry picked from commit 585d0a0)
Hi @ripta. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @chrislovecnm Ready for review. |
/ok-to-test |
Thanks @ripta - I also appreciate it being a focused fix, as it makes it easier to apply at this stage in the cycle, even if we'll likely want to broaden it in future. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, ripta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes #5378.
On CoreOS Container Linux,
/usr/share/logrotate/logrotate.conf
(which is on a read-only mount) enablesdateext
, which causes maxsize-based log rotation to fail when a previous rotation already happened on the calendar same day. This has the undesirable effect that kube-system logs in /var/log grow unbounded until it dominates and fills up/
.