Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automagically use curl instead of wget if that's what's available #6090

Merged

Conversation

eherot
Copy link
Contributor

@eherot eherot commented Nov 16, 2018

This should make things run a little more smoothly on Macs.

@k8s-ci-robot
Copy link
Contributor

Hi @eherot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 16, 2018
wget -O ${addon} https://raw.githubusercontent.com/kubernetes/kops/master/addons/cluster-autoscaler/v1.8.0.yaml
manifest_url=https://raw.githubusercontent.com/kubernetes/kops/master/addons/cluster-autoscaler/v1.8.0.yaml

if which -s wget; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I don't think -s is supported on linux.

You could use this trick: https://github.com/kubernetes/kubernetes/blob/6696ae39ee7df5323e843d93c6146e51d297a299/cluster/get-kube-local.sh#L132

@justinsb
Copy link
Member

I don't think we can use -s I'm afraid, but otherwise looks good

@justinsb justinsb self-assigned this Nov 18, 2018
@justinsb justinsb added this to the 1.12 milestone Nov 18, 2018
@justinsb
Copy link
Member

(This isn't bundled into the release artifact, so I'm putting this into the 1.12 milestone because it doesn't need to impact 1.11 release timelines)

@mikesplain
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 27, 2018
@justinsb
Copy link
Member

@eherot does my comment about which not supporting -s make sense? I think you can just use the $(...) trick I linked instead

@eherot
Copy link
Contributor Author

eherot commented Nov 27, 2018

@justinsb Yes! Just got distracted and haven't implemented your suggestion yet but I do plan to do so.

@justinsb
Copy link
Member

Thanks @eherot

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eherot, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2018
@k8s-ci-robot k8s-ci-robot merged commit 323b51a into kubernetes:master Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants