kops version: Add --short flag, use it to get version in scripts #6232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
justinsb
force-pushed
the
ask_kops_for_its_version
branch
2 times, most recently
from
2f491df to
d70243c
Compare
|
I believe this one now depends on #6245 |
mikesplain
approved these changes
Dec 21, 2018
There was a problem hiding this comment.
Ahh yeah, very nice idea. I can remove the greps and cuts from all my scripts!
Thanks @justinsb!
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
justinsb
force-pushed
the
ask_kops_for_its_version
branch
from
d70243c to
d2a7a2f
Compare
k8s-ci-robot
removed
the
lgtm
|
I had to rebase so this one has lost lgtm... |
k8s-ci-robot
added
the
needs-rebase
justinsb
force-pushed
the
ask_kops_for_its_version
branch
from
d2a7a2f to
b8c5d93
Compare
k8s-ci-robot
removed
the
needs-rebase
We upload to a location that includes the version, but we need to specify the version in KOPS_BASE_URL. We expose an option to make `kops version` more amenable to this scripting.
justinsb
force-pushed
the
ask_kops_for_its_version
branch
from
b8c5d93 to
b40c903
Compare
|
Thanks again @justinsb! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We upload to a location that includes the version, but we need to
specify the version in KOPS_BASE_URL. We expose an option to make
kops versionmore amenable to this scripting.