-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk spelling fixes #6242
Bulk spelling fixes #6242
Conversation
No rush on this one. Tip for anyone feeling keen though - switch to "Split" view in the github PR window. |
Experimenting with my own spelling checker, these are the typos it caught.
d6433ab
to
26bd75a
Compare
Both /lgtm |
@@ -219,7 +219,7 @@ func (c *NodeupModelContext) BuildKubeConfig(username string, ca, certificate, p | |||
|
|||
yaml, err := kops.ToRawYaml(config) | |||
if err != nil { | |||
return "", fmt.Errorf("error marshalling kubeconfig to yaml: %v", err) | |||
return "", fmt.Errorf("error marshaling kubeconfig to yaml: %v", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both are correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, apparently one L is american english and two is british english. While I would love to use the british form as it looks more correct to my eyes, I think it's worth just having everything in one form for consistency, and it probably should be the american form. Even if that means no u in color or favorite :-(
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Experimenting with my own spelling checker, these are the typos it caught.