Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudmock: replace unimplemented methods with interface embedding #6243

Merged
merged 1 commit into from
Dec 21, 2018
Merged

cloudmock: replace unimplemented methods with interface embedding #6243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cloudmock/aws/mockautoscaling/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ go_library(
"group.go",
"launchconfigurations.go",
"tags.go",
"unimplemented.go",
],
importpath = "k8s.io/kops/cloudmock/aws/mockautoscaling",
visibility = ["//visibility:public"],
Expand Down
4 changes: 3 additions & 1 deletion cloudmock/aws/mockautoscaling/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ import (
)

type MockAutoscaling struct {
mutex sync.Mutex
// Mock out interface
autoscalingiface.AutoScalingAPI

mutex sync.Mutex
Groups map[string]*autoscaling.Group
LaunchConfigurations map[string]*autoscaling.LaunchConfiguration
}
Expand Down
521 changes: 0 additions & 521 deletions cloudmock/aws/mockautoscaling/unimplemented.go
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion cloudmock/aws/mockec2/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ go_library(
"securitygroups.go",
"subnets.go",
"tags.go",
"unimplemented.go",
"volumes.go",
"vpcs.go",
],
Expand Down
2,444 changes: 0 additions & 2,444 deletions cloudmock/aws/mockec2/unimplemented.go
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion cloudmock/aws/mockiam/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ go_library(
"iaminstanceprofile.go",
"iamrole.go",
"iamrolepolicy.go",
"unimplemented.go",
],
importpath = "k8s.io/kops/cloudmock/aws/mockiam",
visibility = ["//visibility:public"],
Expand Down
1,148 changes: 0 additions & 1,148 deletions cloudmock/aws/mockiam/unimplemented.go
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion cloudmock/aws/mockroute53/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ go_library(
srcs = [
"api.go",
"records.go",
"unimplemented.go",
"zones.go",
],
importpath = "k8s.io/kops/cloudmock/aws/mockroute53",
Expand Down
3 changes: 3 additions & 0 deletions cloudmock/aws/mockroute53/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ type zoneInfo struct {
}

type MockRoute53 struct {
// Mock out interface
route53iface.Route53API

mutex sync.Mutex
Zones []*zoneInfo
}
Expand Down
539 changes: 0 additions & 539 deletions cloudmock/aws/mockroute53/unimplemented.go
View file
Open in desktop

This file was deleted.