Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS SDK v1.16.11 #6276

Merged
merged 3 commits into from
Dec 28, 2018
Merged

AWS SDK v1.16.11 #6276

merged 3 commits into from
Dec 28, 2018

Conversation

gambol99
Copy link
Contributor

Updating the AWS SDK to v1.16.11, which in this case is a prerequisite for the mixed instances policy PR

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 28, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 28, 2018
@gambol99 gambol99 mentioned this pull request Dec 28, 2018
Merged
@gambol99
AWS SDK v1.16.11
6bd7d53 
- updating the vendoring for the aws sdk dependency to v1.16.11
@gambol99
- updating the bazel requirements
c15fb4c
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 28, 2018
@gambol99
Copy link
Contributor Author

/test pull-kops-bazel-test

@justinsb
Copy link
Member

Use make dep-ensure to remove some of the invalid files that dep adds!

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 28, 2018
@justinsb
Copy link
Member

/approve
/lgtm

Though the real change comes when we introduce the code that uses it I think :-)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gambol99, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3d6b8a4 into kubernetes:master Dec 28, 2018
@gambol99 gambol99 deleted the aws_deps branch February 22, 2019 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinpercy robinpercy Awaiting requested review from robinpercy

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gambol99 @justinsb @k8s-ci-robot