-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kops 1.12 configuration for calico: use CRDs #6358
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d603152
to
9bd90d0
Compare
/test pull-kops-e2e-kubernetes-aws |
9bd90d0
to
7eb5a68
Compare
FYI I've just approved a PR (#6397) that will conflict with this one (updates apiversions of all addon manifests for v1.12) so will need to reapply the manifest file updates, sorry! |
7eb5a68
to
b4cb55d
Compare
@justinsb is this ready to get merged? Lgtm! Plus really appreciate the efforts to get etcd3 tls only as a default in Kops. |
I really need to setup the kops build process so I can test these things out. Looking forward to getting this in so I can test it out. |
@chrisz100 yes I believe this is ready for merge - it's one of the last blockers for 1.12.0-alpha.1 :-) And then that'll also mean you don't need to do the build process @sstarcher - though it is much easier (well at least faster) now, if we ignore the time to download bazel 😛 |
/lgtm :) |
In kops 1.12 (I am proposing) we move to etcd3 with TLS and no external access.
Calico must move to use CRDs therefore; this is a disruptive upgrade cf #6408