Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kops 1.12 configuration for calico: use CRDs #6358

Merged
merged 1 commit into from
Mar 18, 2019

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Jan 18, 2019

In kops 1.12 (I am proposing) we move to etcd3 with TLS and no external access.

Calico must move to use CRDs therefore; this is a disruptive upgrade cf #6408

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2019
@justinsb justinsb changed the title kops 1.12 configuration for calico: use CRDs WIP: kops 1.12 configuration for calico: use CRDs Jan 18, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2019
@justinsb justinsb force-pushed the calico_with_crds branch 2 times, most recently from d603152 to 9bd90d0 Compare January 28, 2019 18:13
@justinsb justinsb changed the title WIP: kops 1.12 configuration for calico: use CRDs kops 1.12 configuration for calico: use CRDs Jan 28, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2019
@chrisz100
Copy link
Contributor

/test pull-kops-e2e-kubernetes-aws

@sstarcher
Copy link
Contributor

@justinsb is this ready for test I'm hoping it will resolve my issue with migration from calico 2 -> 3
#6261

@KashifSaadat
Copy link
Contributor

FYI I've just approved a PR (#6397) that will conflict with this one (updates apiversions of all addon manifests for v1.12) so will need to reapply the manifest file updates, sorry!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2019
@justinsb justinsb added this to the 1.12 milestone Mar 14, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2019
@chrisz100
Copy link
Contributor

@justinsb is this ready to get merged? Lgtm! Plus really appreciate the efforts to get etcd3 tls only as a default in Kops.

@sstarcher
Copy link
Contributor

I really need to setup the kops build process so I can test these things out. Looking forward to getting this in so I can test it out.

@justinsb
Copy link
Member Author

justinsb commented Mar 18, 2019

@chrisz100 yes I believe this is ready for merge - it's one of the last blockers for 1.12.0-alpha.1 :-)

And then that'll also mean you don't need to do the build process @sstarcher - though it is much easier (well at least faster) now, if we ignore the time to download bazel 😛

@chrisz100
Copy link
Contributor

/lgtm

:)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 024749e into kubernetes:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. blocks-next cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants