Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix openstack lb pool member logic #6388

Merged
merged 1 commit into from
Jan 27, 2019
Merged

fix openstack lb pool member logic #6388

merged 1 commit into from
Jan 27, 2019

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented Jan 24, 2019

without this PR the kops will always show in kops update that there is need for add new loadbalancer members. After this PR it will not do that if not really needed

/sig openstack

@k8s-ci-robot k8s-ci-robot added area/provider/openstack Issues or PRs related to openstack provider size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2019
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 24, 2019
@zetaab
fix lb pool member logic
c93bedf 
add getpool function

fix govet
drekle
drekle approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@drekle drekle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 26, 2019 •
edited
Loading

@zetaab: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kops-verify-govet f3d3c2b link /test pull-kops-verify-govet
pull-kops-e2e-kubernetes-aws 23cff46 link /test pull-kops-e2e-kubernetes-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zetaab
Copy link
Member Author

zetaab commented Jan 26, 2019

/retest

@mikesplain
Copy link
Contributor

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit a7ce176 into kubernetes:master Jan 27, 2019
@zetaab zetaab deleted the fixpools branch September 21, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drekle drekle drekle approved these changes

@chrisz100 chrisz100 Awaiting requested review from chrisz100

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zetaab @k8s-ci-robot @mikesplain @drekle