Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permission for CreateTag on ENI to amazon-vpc-cni-k8s #6389

Merged
merged 2 commits into from
Feb 16, 2019
Merged

Add permission for CreateTag on ENI to amazon-vpc-cni-k8s #6389

merged 2 commits into from
Feb 16, 2019

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Jan 24, 2019

Although amazon-vpc-cni-k8s adds tag to ENI, kops does not add the
permission. Hence it does not work by default.

This patch adds the permission for CreateTag on ENI to
amazon-vpc-cni-k8s's nodes policy.

Currently cluster gets following error by default. (And this error could be solved by adding permission.)

2019-01-24T07:39:08Z [WARN] Failed to tag the newly created eni eni-08dda1a05fb50d64b:  UnauthorizedOperation: You are not authorized to perform this operation. .. snip ..

@k8s-ci-robot
Copy link
Contributor

Hi @nak3. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2019
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 24, 2019
@nak3 nak3 mentioned this pull request Jan 24, 2019
Closed
@nak3
Copy link
Contributor Author

nak3 commented Jan 24, 2019 •
edited
Loading

It looks like aws/amazon-vpc-cni-k8s#129 changed to CreateTags from TagResources. I am wondering if TagResources should be deleted, but keep it for safe.

@nak3
Add permission for CreateTag on ENI to amazon-vpc-cni-k8s
92689c5 
Although amazon-vpc-cni-k8s adds tag to ENI, kops does not add the
permission. Hence it does not work by default.

This patch adds the permission for CreateTag on ENI to
amazon-vpc-cni-k8s's nodes policy.
@nak3
Copy link
Contributor Author

nak3 commented Jan 25, 2019

/assign @justinsb
Current requirement for the IAM policy is here https://github.com/aws/amazon-vpc-cni-k8s#setup. This patch added "ec2:CreateTags" which is missing.

@mikesplain
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 25, 2019
mikesplain
mikesplain suggested changes Jan 27, 2019
View reviewed changes
Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nak3! This looks pretty good, can you update the docs here with the additional permission added?

Thanks!

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 28, 2019
@nak3
Copy link
Contributor Author

nak3 commented Jan 28, 2019

@mikesplain Thank you. Updated.

@mikesplain
Copy link
Contributor

Thanks @nak3!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2019
@nak3
Copy link
Contributor Author

nak3 commented Jan 31, 2019

/test pull-kops-e2e-kubernetes-aws

5 similar comments
@nak3
Copy link
Contributor Author

nak3 commented Jan 31, 2019

/test pull-kops-e2e-kubernetes-aws

@nak3
Copy link
Contributor Author

nak3 commented Feb 2, 2019

/test pull-kops-e2e-kubernetes-aws

@nak3
Copy link
Contributor Author

nak3 commented Feb 2, 2019

/test pull-kops-e2e-kubernetes-aws

@nak3
Copy link
Contributor Author

nak3 commented Feb 3, 2019

/test pull-kops-e2e-kubernetes-aws

@nak3
Copy link
Contributor Author

nak3 commented Feb 3, 2019

/test pull-kops-e2e-kubernetes-aws

@nak3
Copy link
Contributor Author

nak3 commented Feb 6, 2019

/test pull-kops-e2e-kubernetes-aws

@nak3
Copy link
Contributor Author

nak3 commented Feb 14, 2019

/test pull-kops-e2e-kubernetes-aws

@nak3
Copy link
Contributor Author

nak3 commented Feb 15, 2019

/test pull-kops-e2e-kubernetes-aws

@nak3
Copy link
Contributor Author

nak3 commented Feb 15, 2019

@mikesplain @justinsb I'm sorry bothering you, but does this PR need to pass all test? I am pretty sure that the current test failure is not related to this PR.

@zetaab
Copy link
Member

zetaab commented Feb 16, 2019

/test pull-kops-e2e-kubernetes-aws

@k8s-ci-robot k8s-ci-robot merged commit d9615fc into kubernetes:master Feb 16, 2019
@nak3 nak3 deleted the eks-tag branch February 17, 2019 00:22
@nak3
Copy link
Contributor Author

nak3 commented Feb 17, 2019

Thank you @zetaab

This was referenced Apr 8, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesplain mikesplain mikesplain requested changes

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@justinsb justinsb

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nak3 @k8s-ci-robot @mikesplain @zetaab @justinsb