Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support both octavia and old lbaasv2 api in openstack #6438

Merged
merged 1 commit into from
Feb 20, 2019
Merged

support both octavia and old lbaasv2 api in openstack #6438

merged 1 commit into from
Feb 20, 2019

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented Feb 3, 2019

fixes #6437

/sig openstack

@k8s-ci-robot k8s-ci-robot added area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 3, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 3, 2019
@zetaab zetaab force-pushed the octavia branch 2 times, most recently from 34b857f to 77401d3 Compare February 3, 2019 16:26
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2019
chrisz100
chrisz100 approved these changes Feb 3, 2019
View reviewed changes
Copy link
Contributor

@chrisz100 chrisz100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2019
@zetaab
Copy link
Member Author

zetaab commented Feb 4, 2019 •
edited
Loading

/hold

There is one bug that we should always wait that LB is in active state before we can add listener/pools to it. LB resources in openstack is immutable when those are in PENDING_* state. Currently it will return lots of errors because of this. I will fix this before this is merged.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2019
@zetaab
Copy link
Member Author

zetaab commented Feb 5, 2019 •
edited
Loading

/hold cancel

now its ready and looks like following:

I0205 16:29:19.843784   52100 executor.go:103] Tasks: 71 done / 79 total; 4 can run
I0205 16:29:20.558386   52100 lb.go:74] Waiting for Loadbalancer to be ACTIVE...
I0205 16:29:21.610390   52100 lb.go:74] Waiting for Loadbalancer to be ACTIVE...
I0205 16:29:22.856263   52100 lb.go:74] Waiting for Loadbalancer to be ACTIVE...
I0205 16:29:24.337667   52100 lb.go:74] Waiting for Loadbalancer to be ACTIVE...
I0205 16:29:25.375800   52100 context.go:231] hit maximum retries 4 with error GetFloatingIP: fetching floating IP failed: Resource not found
I0205 16:29:26.101690   52100 lb.go:74] Waiting for Loadbalancer to be ACTIVE...
I0205 16:29:28.230764   52100 lb.go:74] Waiting for Loadbalancer to be ACTIVE...
I0205 16:29:30.760928   52100 lb.go:74] Waiting for Loadbalancer to be ACTIVE...
I0205 16:29:33.799347   52100 lb.go:74] Waiting for Loadbalancer to be ACTIVE...
I0205 16:29:37.421187   52100 lb.go:74] Waiting for Loadbalancer to be ACTIVE...
I0205 16:29:41.761765   52100 lb.go:74] Waiting for Loadbalancer to be ACTIVE...
I0205 16:29:46.975305   52100 lb.go:74] Waiting for Loadbalancer to be ACTIVE...
I0205 16:29:53.210504   52100 lb.go:74] Waiting for Loadbalancer to be ACTIVE...
I0205 16:30:00.697665   52100 lb.go:74] Waiting for Loadbalancer to be ACTIVE...
I0205 16:30:09.644859   52100 lb.go:74] Waiting for Loadbalancer to be ACTIVE...
I0205 16:30:20.386935   52100 lb.go:74] Waiting for Loadbalancer to be ACTIVE...
I0205 16:30:33.255127   52100 lb.go:74] Waiting for Loadbalancer to be ACTIVE...
I0205 16:30:48.707058   52100 lb.go:74] Waiting for Loadbalancer to be ACTIVE...
I0205 16:31:07.249153   52100 lb.go:74] Waiting for Loadbalancer to be ACTIVE...
W0205 16:31:29.590818   52100 executor.go:130] error running task "Keypair/master" (7m50s remaining to succeed): error finding address for *openstacktasks.FloatingIP {"Name":"fip-api.oma.k8s.local","ID":"0004ffc1-3acb-4080-bb46-603f82166cca","Server":null,"LB":{"ID":"a9a56dd7-233e-4e3e-9cbf-66078058d8d9","Name":"api.oma.k8s.local","Subnet":"nova.oma.k8s.local","VipSubnet":"8cc71087-fee9-4975-a05e-96b2df335fc8","Lifecycle":"Sync","PortID":"eade07b7-7291-48b0-8322-dde0c0596aca"},"Lifecycle":"Sync"}: GetFloatingIP: fetching floating IP failed: Resource not found
I0205 16:31:29.590895   52100 executor.go:103] Tasks: 74 done / 79 total; 5 can run
I0205 16:31:30.262119   52100 vfs_castore.go:729] Issuing new certificate: "master"
I0205 16:31:36.646586   52100 executor.go:103] Tasks: 79 done / 79 total; 0 can run
I0205 16:31:36.899274   52100 update_cluster.go:290] Exporting kubecfg for cluster
kops has set your kubectl context to oma.k8s.local

Cluster is starting.  It should be ready in a few minutes.

(some errors there but those are fixed in another PRs). So it will print message when its waiting that LB is ready. It takes sometimes (about 2 minutes for me in devstack)

edit: btw and why it is waiting for loadbalancer? It is waiting for loadbalancer because after loadbalancer is created it will create listener, pool and poolmembers for it. Those cannot be added before the loadbalance is in state where it is not immutable (pending_* modes)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2019
@zetaab
Copy link
Member Author

zetaab commented Feb 16, 2019

/test pull-kops-e2e-kubernetes-aws

@chrisz100
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2019
@zetaab
Copy link
Member Author

zetaab commented Feb 19, 2019

/assign @mikesplain

@mikesplain
Copy link
Contributor

Thanks @zetaab!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2019
@zetaab
Copy link
Member Author

zetaab commented Feb 20, 2019

/test pull-kops-e2e-kubernetes-aws

@k8s-ci-robot k8s-ci-robot merged commit 2094ef7 into kubernetes:master Feb 20, 2019
@zetaab zetaab deleted the octavia branch February 20, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisz100 chrisz100 chrisz100 approved these changes

@drekle drekle drekle approved these changes

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@chrisz100 chrisz100

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support openstack octavia
5 participants
@zetaab @chrisz100 @mikesplain @k8s-ci-robot @drekle