-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package task: cleaner behaviour when package is installed #6490
package task: cleaner behaviour when package is installed #6490
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lgtm, looks like you need to update a few tests for the |
Doh! Thanks @mikesplain ! |
e79998a
to
5a11677
Compare
/retest Known flake: kubernetes/kubernetes#73099 |
@justinsb please rebase |
5a11677
to
8120e74
Compare
8120e74
to
9e41a19
Compare
I think this is now going to interact poorly with ExtraDeps on the package. I do think we need to revisit - maybe we don't make the deps explicit, but we just always install all missing packages in one command invocation |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Ignore fields that help us locate the source package, also remove the unused PreventStart field.
9e41a19
to
1ef9fdc
Compare
@justinsb: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ignore fields that help us locate the source package, also remove the
unused PreventStart field.