Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package task: cleaner behaviour when package is installed #6490

Conversation

justinsb
Copy link
Member

Ignore fields that help us locate the source package, also remove the
unused PreventStart field.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2019
@mikesplain
Copy link
Contributor

lgtm, looks like you need to update a few tests for the PreventStart change since it's been removed.

@justinsb
Copy link
Member Author

Doh! Thanks @mikesplain !

@justinsb justinsb force-pushed the fix_package_task_second_invocation branch from e79998a to 5a11677 Compare February 20, 2019 14:31
@justinsb
Copy link
Member Author

/retest

Known flake: kubernetes/kubernetes#73099

@zetaab
Copy link
Member

zetaab commented Feb 26, 2019

@justinsb please rebase

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2019
@justinsb justinsb force-pushed the fix_package_task_second_invocation branch from 5a11677 to 8120e74 Compare March 14, 2019 04:34
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2019
@justinsb justinsb added this to the 1.12 milestone Mar 15, 2019
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2019
@justinsb justinsb force-pushed the fix_package_task_second_invocation branch from 8120e74 to 9e41a19 Compare March 18, 2019 04:08
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2019
@justinsb justinsb modified the milestones: 1.12, 1.13 Mar 18, 2019
@justinsb
Copy link
Member Author

I think this is now going to interact poorly with ExtraDeps on the package. I do think we need to revisit - maybe we don't make the deps explicit, but we just always install all missing packages in one command invocation

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 16, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 16, 2019
Ignore fields that help us locate the source package, also remove the
unused PreventStart field.
@justinsb justinsb force-pushed the fix_package_task_second_invocation branch from 9e41a19 to 1ef9fdc Compare July 19, 2019 11:39
@k8s-ci-robot
Copy link
Contributor

@justinsb: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kops-bazel-build 1ef9fdc link /test pull-kops-bazel-build
pull-kops-bazel-test 1ef9fdc link /test pull-kops-bazel-test
pull-kops-verify-govet 1ef9fdc link /test pull-kops-verify-govet
pull-kops-e2e-kubernetes-aws 1ef9fdc link /test pull-kops-e2e-kubernetes-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants